Fix installation testing workflow errors on PHP <= 7.3 with MySQL 8.4#11250
Closed
desrosj wants to merge 2 commits intoWordPress:trunkfrom
Closed
Fix installation testing workflow errors on PHP <= 7.3 with MySQL 8.4#11250desrosj wants to merge 2 commits intoWordPress:trunkfrom
desrosj wants to merge 2 commits intoWordPress:trunkfrom
Conversation
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
Member
Author
|
This is ready to go. Since you can't run a |
Member
Author
|
Merged in r62022. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This addresses installation test failures on older branches caused by authentication plugin changes in MySQL:
caching_sha2_password, which did not exist on PHP <= 7.3. The previous behavior can be restored using--default-authentication-plugin=mysql_native_password.--authentication-policy.mysql_native_passwordwas removed entirely.The last scenario is already guarded against through
excludestatements. But the current conditional statement in the workflow:This adjusts the conditional statements to fully account for all scenarios.
A workaround for this was previously included in
trunk, but has since been removed when PHP 7.3 was dropped earlier in the 7.0 release cycle. There is helpful history and details in r59277, which merged support for MySQL 8.4 in the local Docker environment. The custom .conf file in particular has good inline documentation.Trac ticket: Core-64227.
Use of AI Tools
Claude was used to collect research and generate the first draft of this PR.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.